search

vmware-archive / pcf-pipelines

PCF Pipelines
Apache License 2.0
158 stars 282 forks source link

don't be so greedy #388

Closed pivotal-ben-chacko closed 5 years ago

pivotal-ben-chacko commented 5 years ago

Thanks for submitting an pull request to pcf-pipelines.

To speed up the process of reviewing your pull request please provide us with:

OpsMan 2.4

$> cat OpsManager2.4-build.192onGCP.yml

us: ops-manager-us/pcf-gcp-2.4-build.192.tar.gz eu: ops-manager-us/pcf-gcp-2.4-build.192.tar.gz asia: ops-manager-us/pcf-gcp-2.4-build.192.tar.gz

This results in grep matching more then one occurrence of the pattern. This leads to the following incorrect new yml file from being created.

disk_image_url: ops-manager-us/pcf-gcp-2.3-build.305.tar.gz ops-manager-us/pcf-gcp-2.3-build.305.tar.gz ops-manager-us/pcf-gcp-2.3-build.305.tar.gz

Notice the 2 additional values being inserted in the key value pair.

The proposed pull request would limit the regex matching to one occurrence, when grep is run.

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

pivotal-issuemaster commented 5 years ago

@pivotal-ben-chacko Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 5 years ago

@pivotal-ben-chacko Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 5 years ago

@pivotal-ben-chacko Thank you for signing the Contributor License Agreement!

kcboyle commented 5 years ago

merged via command line.

This is being merged in because this is a breaking change for current pipelines.

This will be included in the next (last) release of pcf-pipelines. This feature has not been tested by CI, nor will it be. Use this commit and the corresponding release at your own risk.

In the future, please use platform-automation for all your automation needs. Pivotal Documentation