search

vmware-archive / pcf-prometheus-pipeline

Apache License 2.0
20 stars 38 forks source link

Add route-registrar for friendlier PCF urls #24

Closed rmeharg closed 5 years ago

mkuratczyk commented 5 years ago

Thanks Ryan!

DenverOps commented 5 years ago

@mkuratczyk should I put in an issue for the new Route Registrar? I believe it's broke per our last chat.

mkuratczyk commented 5 years ago

I've just pushed https://github.com/pivotal-cf/pcf-prometheus-pipeline/commit/ba4b798d79c2eaa999bbe689e98bb3cf2d155b5c to disable it by default.

@RMeharg there are a few problems with this:

  1. It fails when deploying to an external BOSH director
  2. It's explicit about release versions with but doesn't actually upload these versions
  3. Even if the releases are there, sometimes they are only available as compiled for xenial stemcells so it still fails trying to deploy to trusty (we can change the default to xenial soon I guess)
rmeharg commented 5 years ago

@mkuratczyk good points

  1. Yes, it has to be on the same director as CF until we have cross-director links (https://github.com/cloudfoundry/bosh-notes/blob/master/proposals/cross-director-links.png)
  2. I'm not sure I understand, it follows the same format as prometheus-boshrelease, we could use github-release resource if it wasn't optional
  3. All releases should be switching to xenial as soon as possible :)

I am fine with leaving this as an optional operations file.