Open nickkhg opened 2 years ago
Notes on the functionality:
Visual (desktop size, on the happy column):
Inactive | Hover | Active |
---|---|---|
Previous discussion on ordering/sorting items:
@textbook Thank you for the detailed description of the feature and the links to the issues, no idea how I missed them! I've read through the replies on there and saw it's against the product philosophy, but I would argue this is very much dependent on the team. Sorting by the number of votes doesn't necessarily mean that the entries with no votes won't be discussed, but it's rather more of a matter of prioritisation.
Is this something that would still be considered?
Hey @textbook I totally get your point. But I think some teams might work different or postfacto is used in a big cross team audience, so that is might be needed to order by likes due to time constraints. I would like to suggest the following why not adding a flag to the configuration file wether the the sort option is available/useable or not. So each team can decide if they want to use it or not.
Thanks for contributing to postfacto. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change: This PR adds a toggle button on the retro page which allows the client to sort the list of items in each column by the number of votes it has received.
An explanation of the use cases your change solves This is useful for the discussions that follow the addition of items, so that the conversations can be held in order of importance, as voted by the team. Oftentimes the columns can get quite long, so having this simple feature could help a lot.
Links to any other associated PRs (-)
[x] I have reviewed the contributing guide
[x] I have made this pull request to the
master
branch[x] I have run all the tests using
./test.sh
.[N/A] I have added the copyright headers to each new file added
[x] I have given myself credit in the humans.txt file (assuming I want to)