search

vmware-archive / powernsx

PowerShell module that abstracts the VMware NSX-v API to a set of easily used PowerShell functions
173 stars 89 forks source link

Add IPsec cmdlets (for ESG) #498

Closed alagoutte closed 5 years ago

alagoutte commented 6 years ago

Add 4 new cmdlets for Get/Set/Remove/Add(Site) -NsxIPsec

add also test suite

It will be fixed #438

BasvanH commented 6 years ago

Please merge this request.

alagoutte commented 6 years ago

@nmbradford, it is possible to get feedback on this PR ? (Launch testsuite ?)

alagoutte commented 5 years ago

Hi @dcoghlan, can you launch test suite ?

dcoghlan commented 5 years ago

jenkins test this please

powernsxbot commented 5 years ago

Tests Failed

dcoghlan commented 5 years ago

@alagoutte your tests for this PR have failed as per the output below


  Describing Edge IPsec
Using existing PowerCLI connection to 192.168.172.88
WARNING: Using cluster Mgmt01_a for clustery stuff
WARNING: Using datastore MgmtData for datastorey stuff
    Context ipsec
      [+] Can retrieve IPsec Config 56.48s
      [+] Disabled logging 5.2s
      [+] Change logging level 2.41s
      [+] Add First IPsec Site (with PSK) 2.93s
      [+] Enable IPsec Server 5.64s
      [-] Add Second IPsec Site (with PSK and disable pfs but use dh2 and encryption AES256) 5.86s
        String lengths are both 8. Strings differ at index 7.
        Expected: {localid2}
        But was:  {localid1}
        ------------------^
        at <ScriptBlock>, C:\jenkins\workspace\WindowsPowerNsx641\tests\integration\18.IPsec.tests.ps1: line 112
        112:             $ipsec.sites.site.localid[0] | should be "localid2"
      [+] Config global IPsec settings 4.29s
      [-] Add Third IPsec Site (with certificate) 5.52s
        String lengths are both 8. Strings differ at index 7.
        Expected: {localid3}
        But was:  {localid2}
        ------------------^
        at <ScriptBlock>, C:\jenkins\workspace\WindowsPowerNsx641\tests\integration\18.IPsec.tests.ps1: line 135
        135:             $ipsec.sites.site.localid[0] | should be "localid3"
      [+] Remove IPsec Config 5.05s
powernsxbot commented 5 years ago

Tests Failed

alagoutte commented 5 years ago

it is good now ?

powernsxbot commented 5 years ago

Tests Failed

alagoutte commented 5 years ago

it is good ?

dcoghlan commented 5 years ago

jenkins test this please

powernsxbot commented 5 years ago

Tests Failed

dcoghlan commented 5 years ago

jenkins test this please

powernsxbot commented 5 years ago

Tests Failed

dcoghlan commented 5 years ago

jenkins test this please

powernsxbot commented 5 years ago

Tests Successful

alagoutte commented 5 years ago

Thanks !