search

vmware-archive / powernsx

PowerShell module that abstracts the VMware NSX-v API to a set of easily used PowerShell functions
173 stars 89 forks source link

New-NsxEdgeInterfaceSpec: Switch EnableSendICMPRedirects does not make sense #512

Open vMarkusK opened 6 years ago

vMarkusK commented 6 years ago

ICMP-Redirects are enabled by default within this Function. So the switch should be DisableSendICMPRedirects .

nmbradford commented 6 years ago

Agree with language choice being suboptimal, but its a breaking change to remove the existing switch. We could add a new one though its low priority. Semantics aside, remember a switch is negatable. You can disable ICMP redirects with -EnableSendICMPRedirects:$false, so functionally you are covered.