vmware-archive / powernsx

PowerShell module that abstracts the VMware NSX-v API to a set of easily used PowerShell functions
173 stars 89 forks source link

Edge: Update minimum Ha DeadTime limit #516

Closed alagoutte closed 5 years ago

alagoutte commented 6 years ago

it is now 3 secs (before 6secs)

Fix issue #513

dcoghlan commented 6 years ago

Hey @alagoutte, If you can write some tests for this, it looks like a fairly easy one to merge.

alagoutte commented 6 years ago

Hi Dane,

it is a small change... What test do you want ?

nmbradford commented 6 years ago

Just a simple 'can I set it' and 'When I set it, does the returned object have it set as I asked' style tests. Just the two is fine.

alagoutte commented 6 years ago

It is a quick fix...

and there is no test for the moment for HA... And need to create a new Edge (you don't modified a setting from a Edge...)

nmbradford commented 6 years ago

You can just included it in the existing edge tests.

alagoutte commented 6 years ago

No found test with HA...

nmbradford commented 6 years ago

You will note I didn't claim there was. Just create a single test for this in the existing edge tests.

alagoutte commented 5 years ago

Adding a HA Tests

Can you launch test suite ?

dcoghlan commented 5 years ago

jenkins test this please

powernsxbot commented 5 years ago

Tests Failed

dcoghlan commented 5 years ago

jenkins test this please

powernsxbot commented 5 years ago

Tests Failed

dcoghlan commented 5 years ago

jenkins test this please

powernsxbot commented 5 years ago

Tests Failed

dcoghlan commented 5 years ago

jenkins test this please

powernsxbot commented 5 years ago

Tests Failed

dcoghlan commented 5 years ago

Tests failed due to testing harness failures. Your changes passed successfully.