search

vmware-archive / powernsx

PowerShell module that abstracts the VMware NSX-v API to a set of easily used PowerShell functions
173 stars 89 forks source link

Resolve Issue 566 #567

Closed NamedJason closed 3 years ago

NamedJason commented 5 years ago

I added a line to allow remove-nsxSecurityGroupMember to properly detect excludeMember objects so that it can remove them.

I'm sorry if I'm doing this wrong, I'm a beginner with Git. Please let me know if I need to do something differently.

vmwclabot commented 5 years ago

@NamedJason, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot commented 5 years ago

@NamedJason, VMware has approved your signed contributor license agreement.

alagoutte commented 5 years ago

Hi @NamedJason

There is a issue when you change it is very big (you don't have change all indent ?)

NamedJason commented 5 years ago

Ok. I used tabs for indents on my new lines, but then I saw that the rest of the file uses spaces, so that second edit was just me changing my new lines to use spaces, too.

From: Alexis La Goutte notifications@github.com Sent: Monday, February 18, 2019 7:05 AM To: vmware/powernsx Cc: NamedJason; Mention Subject: Re: [vmware/powernsx] Resolve Issue 566 (#567)

Hi @NamedJasonhttps://github.com/NamedJason

There is a issue when you change it is very big (you don't have change all indent ?)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/vmware/powernsx/pull/567#issuecomment-464765662, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AObTCVARu81dVhOpXCH7KhV8huyqR7Dkks5vOsFTgaJpZM4ac9uP.

alagoutte commented 5 years ago

What editor do you have using ?

NamedJason commented 5 years ago

NPP - I usually use tabs, so I just did so here in my initial version. When I uploaded it to github, it looked funky and that's when I realized that the rest of the file uses spaces instead, so I changed to try and follow the existing style.

From: Alexis La Goutte notifications@github.com Sent: Monday, February 18, 2019 9:49 AM To: vmware/powernsx Cc: NamedJason; Mention Subject: Re: [vmware/powernsx] Resolve Issue 566 (#567)

What editor do you have using ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/vmware/powernsx/pull/567#issuecomment-464826305, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AObTCQOIbbnx0Mr1oEMXvRMgo_WcBUl5ks5vOufEgaJpZM4ac9uP.

dcoghlan commented 3 years ago

fixed by #647