search

vmware-archive / powernsx

PowerShell module that abstracts the VMware NSX-v API to a set of easily used PowerShell functions
173 stars 90 forks source link

Add Set-NsxEdgeFirewallRule #571

Closed alagoutte closed 5 years ago

alagoutte commented 5 years ago

Add Set-NsxEdgeFirewallRule and tests

Fix #565

dcoghlan commented 5 years ago

jenkins test this please

powernsxbot commented 5 years ago

Tests Failed

alagoutte commented 5 years ago

Hi Dale

Thanks for the jenkins test

it is possible to known why failed ?

dcoghlan commented 5 years ago

Hi Dale

Thanks for the jenkins test

it is possible to known why failed ?

It was a spelling mistake in the tests. I've made some suggestions on where the spelling errors are. Once they are fixed, we will run it through the tests again and merge if it passes

alagoutte commented 5 years ago

Oups push the wrong commit

can you retest ?

dcoghlan commented 5 years ago

jenkins test this please

powernsxbot commented 5 years ago

Tests Failed

dcoghlan commented 5 years ago

Tests failed with the following error

MESSAGE:
Expected $false, but got 'false'.
+++++++++++++++++++
STACK TRACE:
at <ScriptBlock>, /var/jenkins/workspace/CorePowerNsx641/tests/integration/04.Edge.Tests.ps1: line 563
563:             $rule.loggingEnabled | should be $false
alagoutte commented 5 years ago

Thanks!

can you relaunch test ?

dcoghlan commented 5 years ago

jenkins test this please

powernsxbot commented 5 years ago

Tests Failed

dcoghlan commented 5 years ago

Test failed due to the function not being exported. Please add the function to /module/include.ps1


MESSAGE:
The term 'Set-NsxEdgeFirewallRule' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
+++++++++++++++++++
STACK TRACE:
at <ScriptBlock>, C:\jenkins\workspace\WindowsPowerNsx641\tests\integration\04.Edge.Tests.ps1: line 567
567:             $rule = $rule | Set-NsxEdgeFirewallRule -name "testrule21" -comment "testrule21" -loggingEnabled $true -enabled $false -action deny```
alagoutte commented 5 years ago

Sorry, Add Set-NsxEdgeFirewallRule to module/Include.ps1

dcoghlan commented 5 years ago

jenkins test this please

dcoghlan commented 5 years ago

Please update test to check for $rule.enabled as a string


        Expected: {False}
        But was:  {false}
        at <ScriptBlock>, C:\jenkins\workspace\WindowsPowerNsx641\tests\integration\04.Edge.Tests.ps1: line 569
        569:             $rule.enabled | should be $false```
powernsxbot commented 5 years ago

Tests Failed

alagoutte commented 5 years ago

Done

dcoghlan commented 5 years ago

jenkins test this please

powernsxbot commented 5 years ago

Tests Successful

Mooihoek commented 5 years ago

I just did Update-Module PowerNSX but receive the following error: Set-NsxEdgeFirewallRule : The term 'Set-NsxEdgeFirewallRule' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

Am I missing something? Thought this new command had been included?

alagoutte commented 5 years ago

Hi @Mooihoek

The patch is merged but there is now yet updated release of module on psgallery

You need to manually download master branch (or clone)

Mooihoek commented 5 years ago

Hi @Mooihoek

The patch is merged but there is now yet updated release of module on psgallery

You need to manually download master branch (or clone)

great thanks so much!