search

vmware-archive / projectmonitor

Big Visible Chart CI aggregator
http://ci.pivotallabs.com
BSD 2-Clause "Simplified" License
428 stars 120 forks source link

Rubygems is unreachable #101

Closed professor closed 8 years ago

professor commented 8 years ago

I'd like to suggest that we remove the banner warnings. They seem to occur frequently. It's more noise than signal. Maybe the url changed? If rubygems is down, I'll probably discover it pretty quickly.

Ditto for heroku, github, and the other warning messages.

andistuder commented 8 years ago

Instead of removing, maybe allow disabling via environment variable? Further, as discussed in #97 and #98, it would be better to query the Rubygems status page instead of parsing the webpage.

professor commented 8 years ago

If someone is relying on this behavior, maybe have it be configurable per project monitor. I believe most of us in Palo Alto just ignore it. It is a little embarrassing to have it show up during tours. I had assumed (maybe incorrectly) that it is vestigial code.

schubert commented 8 years ago

Does https://github.com/pivotal/projectmonitor/pull/98 fix this?

andistuder commented 8 years ago

As mentioned on #98 (and #97 which is fix for same issue), it would be better to get the status via JSON API request, instead of parsing the html.

I wrote a fix here building on @Khoulaiz's #97, but waiting to get it adopted.

tjgrathwell commented 8 years ago

I merged in @andistuder's branch, things should be okay now.

I don't deny that the warnings have done more harm than good in the recent past, but hopefully if we can keep on top of these status changes (better than this many-month turnaround 😿 ) it won't be so bad going forward. I think a pull request that does the disable-by-env-variable thing would be cool too.