search

vmware-archive / projectmonitor

Big Visible Chart CI aggregator
http://ci.pivotallabs.com
BSD 2-Clause "Simplified" License
428 stars 120 forks source link

[tddium] Support internally hosted TDDium projects #51

Closed tay closed 9 years ago

tay commented 10 years ago

Support TDDium Enterprise, a privately deployable version of TDDium (https://www.solanolabs.com/#pricing)

NB. TDDium has since rebranded to Solano, so I suspect that the tddium.com URLs that we have hardcoded may be deprecated. But since I don't use the one hosted on their servers, I'm really not sure.

Allow custom instance URL

gsiener commented 9 years ago

Hi @tay, I captured this as a story in our backlog here: https://www.pivotaltracker.com/story/show/84535870

Looks like the issue was a rogue quote (https://github.com/pivotal/projectmonitor/tree/support-hosted-tddium) but this branch is now out of date...

tay commented 9 years ago

@gsiener What do you mean by rogue quote? I am happy to bring this branch up to date but given that it has taken five months for y'all to reply, is there actually a chance of this getting merged in?

gsiener commented 9 years ago

For context -- this is the build that failed: https://travis-ci.org/pivotal/projectmonitor/builds/31488917#L895

Looks like it was failing on this line because of the double quote: https://github.com/pivotal/projectmonitor/pull/51/files#diff-fb312d8dcf15fea2e04d19523d09ff27R452

To answer your question, yes, we can get this merged... sorry for the radio silence

gsiener commented 9 years ago

Hi @tay -- this is now on master as of a29be9cdcb7dcd6cacc99cbf484a5879404772c0

I took your work and merged in the changes that we did recently to abstract concepts like a base_url. So -- hopefully migrating to this shouldn't be that painful. Thanks for the PR and apologies again that we couldn't get this in sooner.