vmware-archive / projectmonitor

Big Visible Chart CI aggregator
http://ci.pivotallabs.com
BSD 2-Clause "Simplified" License
427 stars 120 forks source link

pulse returns 500 for CircleCI webhook #54

Closed brendanbenson closed 8 years ago

brendanbenson commented 10 years ago

We have a project set up in pulse to use webhooks for the build board in the Boulder office. However, when CircleCI pings pulse on a successful build, it gets a 500 error:

screen shot 2014-08-22 at 3 18 23 pm

Our circle.yml is as follows:

notify:
  webhooks:
    - url: http://pulse.pivotallabs.com/projects/our-guid/status
gsiener commented 10 years ago

Hey Brendan. Not sure what's going on here, but I'll check the logs to see if I can find anything of note.

gsiener commented 10 years ago

Hi Brendan, is this still happening? Couldn't find anything specific in the logs. Thanks.

kfitzpatrick commented 9 years ago

@gsiener in my install I see

2014-12-02T19:56:23.316280+00:00 app[web.1]: Started POST "/projects/c6b0d6f2-7408-4964-92ba-ba0baa5ae992/status" for 54.161.108.228 at 2014-12-02 19:56:23 +0000 2014-12-02T19:56:24.982197+00:00 heroku[router]: at=info method=POST path="/projects/c6b0d6f2-7408-4964-92ba-ba0baa5ae992/status" host=tll-project-monitor.herokuapp.com request_id=3afb5665-8934-4e82-8f4d-1bceca1ace53 fwd="54.161.108.228" dyno=web.1 connect=1ms service=1660ms status=500 bytes=991 2014-12-02T19:56:24.968877+00:00 app[web.1]: 2014-12-02T19:56:24.968890+00:00 app[web.1]: 2014-12-02T19:56:24.968887+00:00 app[web.1]: app/controllers/status_controller.rb:6:in create' 2014-12-02T19:56:24.968889+00:00 app[web.1]: 2014-12-02T19:56:24.968885+00:00 app[web.1]: NoMethodError (undefined methodwebhook_payload' for #CircleCiProject:0x007f3226f15a68):

kfitzpatrick commented 9 years ago

It appears that CircleCiProject does not have a #webhook_payload method

gsiener commented 9 years ago

Captured this as a bug here: https://www.pivotaltracker.com/story/show/84535912

objcode commented 9 years ago

@sweetleon and myself made a pull request to fix this https://github.com/pivotal/projectmonitor/pull/76