vmware-archive / projectmonitor

Big Visible Chart CI aggregator
http://ci.pivotallabs.com
BSD 2-Clause "Simplified" License
428 stars 120 forks source link

Semaphore Polling doesn't function #99

Closed mkanthan closed 8 years ago

mkanthan commented 8 years ago

When adding a polling project for Semaphore, a check for branch name from the response returns false since the key doesn't exist where it's referenced in semaphore_payload.rb:

def specified_branch?(content)
  branch == content['branch_name']
end

The problem here is that key branch_name doesn't appear in the content object which is a nested build inside the response. It appears in the top-level response object now (maybe it worked at the time it was written) and so it breaks polling on Semaphore projects. I'll see if I can take a stab at fixing this and submitting a PR.

tjgrathwell commented 8 years ago

Should be fixed now, sorry for the wait.