search

vmware-archive / quickstep

Quickstep Project
Apache License 2.0
27 stars 13 forks source link

Transaction Part 2: AccessMode, ResourceId, Lock #100

Closed hakanmemisoglu closed 8 years ago

hakanmemisoglu commented 8 years ago

This PR introduces new classes for transaction support.

zuyu commented 8 years ago

@hakanmemisoglu You need to run iwyu for all files you've touched and created.

hakanmemisoglu commented 8 years ago

@zuyu Thanks for the feedback. I have installation problems with iwyu. Therefore I could not run it. Let's wait until I can install it.

zuyu commented 8 years ago

@hakanmemisoglu What issues did you encounter during installing iwyu? On Mac, I use brew.

hakanmemisoglu commented 8 years ago

I am using the computer at the office. There is a linker error about non existent shared library. I found the solution, I will try tomorrow.

hakanmemisoglu commented 8 years ago

I pushed the code, but I have not changed the placeholders, and applied iwyu. Let's review it after fixing them.

hakanmemisoglu commented 8 years ago

Hi @zuyu, I pushed the recent changes, and Travis seems happy.

zuyu commented 8 years ago

@hakanmemisoglu After fixing a minor issue in Lock_unittest and squashing the commits, we could merge.

hakanmemisoglu commented 8 years ago

I fixed the issue. I will squash the commits.

zuyu commented 8 years ago

@hakanmemisoglu Please remove the following words in the commit message:

Fixed typos.

Applied the review suggestions.

Applied the fixes.

Applied iwyu fixes for includes.

Unit test for Lock class is added.

Change the placeholder values as invalid ids that are previously used.

Fixed CMakeLists.txt for ResourceId.

Use of invalid id variable instead of magic numbers.

AccessMode underlying type refactored.

Fixed test bloat.

Updated copyright, moved the declaration of kInvalidId below.

Fixed Lock_unittest.
hakanmemisoglu commented 8 years ago

Done.

zuyu commented 8 years ago

LGTM!