search

vmware-archive / quickstep

Quickstep Project
Apache License 2.0
27 stars 13 forks source link

Use an explicit Agent (TMB Client) to send messages to Foreman. #114

Closed zuyu closed 8 years ago

zuyu commented 8 years ago

This PR refactored to use an explicit TMB client (called agent) to send messages on behalf of InsertDestinations and some WorkOrders to Foreman.

The previous implementation uses a globally accessible map to implicitly use Worker's client id as sender, but it is hard to understand / debug.

In the distributed version, Shiftboss would act as the agent so that Foreman could have data locality information based on the message sender's client id for better scheduling on later WorkOrders.

pateljm commented 8 years ago

LTGM. @hbdeshmukh if you have questions, perhaps we can address in a separate PR. Merging to let @zuyu move on to the next PR.