Query Execution State - Githubissues

hbdeshmukh commented 8 years ago

This PR includes creation of a new class called QueryExecutionState. The functionality of the class is related to book keeping of a query execution which inculdes:

Which operators in the DAG have finished their execution.
Whether an operator has produced all of its work orders.
Whether the execution of the query is over.
For an active operator, modifying and retrieving the number of work orders which have been dispatched and the number of work orders which have finished their execution.
Rebuild related information for the relevant operators.

Earlier, all of the supporting data structures were private members of Foreman. Now they have been pulled out in the class QueryExecutionState. As this class is fairly straightforward, and we had all of its functionality earlier in Foreman, I didn't write test cases for this class.

The next PR will be about QueryManager, which moves all the functions about a query's execution from Foreman to a new class called QueryManager.

jianqiao commented 8 years ago

LGTM besides the style suggestions as @zuyu pointed out.

hbdeshmukh commented 8 years ago

Addressed the comments.

hbdeshmukh commented 8 years ago

I am wondering why a Travis build wasn't fired after my two latest commits. I can't find a way to manually trigger a Travis build.

jianqiao commented 8 years ago

Perhaps just revise some comments by one or two words and do one more push.

zuyu commented 8 years ago

@hbdeshmukh It happened to me before. What I did was to close this PR, and then create a new using the same branch.

pateljm commented 8 years ago

Strange. I see a "missing commit" entry in https://travis-ci.org/pivotalsoftware/quickstep/requests. Not sure if that has something to do with it. I think closing this PR and opening it back again should trigger Travis again.

vmware-archive / quickstep

Query Execution State #119