search

vmware-archive / quickstep

Quickstep Project
Apache License 2.0
27 stars 13 forks source link

Add googletest as a submodule #156

Closed hakanmemisoglu closed 8 years ago

hakanmemisoglu commented 8 years ago

This PR removes google test framework source code from Quickstep repository and adds it as a submodule. Fixes #153 Note: It is a part of the speedup Travis.

pateljm commented 8 years ago

LTGM! @zuyu and @hbdeshmukh: Does this look ok to you?

hbdeshmukh commented 8 years ago

I just have one minor comment. Other than that, this looks good to me. Thanks @hakanmemisoglu !

zuyu commented 8 years ago

@hakanmemisoglu @pateljm I've noticed that we are tracing the master branch, an actively development branch, instead of the latest stable, but quite old release version 1.7 on Sep 2013. We use version 1.6, though.

So, fyi, if gtest's master branch moves ahead and we are doing a fresh checkout of Quickstep, we will be forced to use the latest commit of gtest. It is ok, but we need to make sure it won't break anything before committing new changes of gtest to Quickstep.

hbdeshmukh commented 8 years ago

That's a good point @zuyu, I agree. Making sure that everyone checks out the same version of third party libraries can ensure uniformity and should help in debugging build issues.

hakanmemisoglu commented 8 years ago

@zuyu @hbdeshmukh Right now I do not worry about the changes. Latest changes are generally about the typos and text fixes. It seems they are going to release v1.8 at some point soon (related issue). I will add another issue to remind to fix it to 1.8 when it will be available. Edit: Typos.

hakanmemisoglu commented 8 years ago

Note: Thanks for the warning.

hakanmemisoglu commented 8 years ago

@hbdeshmukh I added warnings as you described and Travis looks green.

hakanmemisoglu commented 8 years ago

@hbdeshmukh, I have added an issue #158.

hbdeshmukh commented 8 years ago

Sounds good. Merging.