search

vmware-archive / quickstep

Quickstep Project
Apache License 2.0
27 stars 13 forks source link

Explicitly specify where tcmalloc comes from #235

Closed d closed 8 years ago

d commented 8 years ago

This change adds a declaration that libtcmalloc_minimal.a is generated by the external project. This is needed by the Ninja generator to properly build.

To reproduce: run cmake -GNinja path/to/quickstep then cmake --build path/to/build/dir and see it fails.

pateljm commented 8 years ago

@d. Ok -- I'm rethinking this PR as it builds now in the third_party/gperftools rather than under the build directory. Would you be ok if we revered this PR, by commenting out the change, so that if you need you can build. I think the common case is now broken for all the other developers.

d commented 8 years ago

My understanding is the added BUILD_BYPRODUCTS line has literally no side-effect, that it is merely informing the build system where libtcmalloc_minimal.a is coming from. And about the third_party/gperftools directory, it is actually under the <build directory>/third_party/gperftools

To help unblock everybody, Yes @pateljm please revert. At the meantime to help me understand what I've done wrong, can you please show me the Travis build that was broken? I've checked two places and I figured Travis could have exposed this for us earlier.

Meanwhile, I'm gonna use the Makefile generator to verify that. Apologies for breaking the build!

d commented 8 years ago

Just came back from manual testing, and I can confirm that the Makefile generator will not pollute your source tree with tcmalloc static library files