search

vmware-archive / react-starter

MIT License
30 stars 23 forks source link

Documentation improvements #16

Open saadshakil opened 7 years ago

saadshakil commented 7 years ago

Hello,

Trying to cf push this out of the box doesn't work. There is an error about the public directory not existing. I happen to have it since I happen to run gulp, which I believe created artifacts in the public directory, which is referenced in manifest.yml. It would be nice to have this noted in the README. Also, since the route https://react-starter.cfapps.io is taken, it would be nice to have a note about setting an alternative host in manifest.yml. After this, I'm still unable to cf push, seeing ERR None of the buildpacks detected a compatible application, even though Staticfile is present, and I can see OUT Downloading staticfile_buildpack... in logs, before the above error.

charleshansen commented 7 years ago

Sorry for not noticing this until now. Thanks for the suggestions. I made improvements to the readme, let me know if you think it can be improved.