search

vmware-archive / repository-editor-for-tuf

Command line tool for editing and maintaining a TUF repository
Apache License 2.0
5 stars 3 forks source link

`GitMetadata` and `GitRepository` have almost nothing to do with `git` #60

Closed KOLANICH closed 1 year ago

KOLANICH commented 1 year ago

_git is only called in close and add_target, the rest of functionality should suit any file-based repo of the same structure.

jku commented 1 year ago

Not any file based repo: there are a lot of design decisions encoded in those classes (many not git-related, that's true). There are definitely other file based designs that will not want to make the same decisions.

KOLANICH commented 1 year ago

That's why

of the same structure.

:)

jku commented 1 year ago

GitRepository and GitMetadata combined are less than 200 lines of code: if this issue is saying that they should be further divided into something, it's unlikely to happen in this project.

If the issue is about naming: I think "git" is the defining feature for this Repository implementation.

So closing, please reopen if you disagree with any of those

KOLANICH commented 1 year ago

if this issue is saying that they should be further divided into something

Yes, it was about this.

OK.