search

vmware-archive / runtimes

Kubeless function runtimes: https://kubeless.io/docs/runtimes/
Apache License 2.0
81 stars 89 forks source link

Fixed the issue of metrics for golang runtime #63

Closed Shashankft9 closed 4 years ago

Shashankft9 commented 4 years ago

Issue Ref: https://github.com/kubeless/kubeless/issues/1020

Description: Exposed promhttp.Handler in a function in kubeless/kubeless/pkg/function-proxy/utils/proxy-utils.goand invoked that function here in stable/golang/kubeless.tpl.go. There are some further changes in the kubeless/kubeless repo.

Gave the script compile-function.sh the permission to run in the Dockerfile, otherwise the compile init-container of a kubeless function displays error status.

andresmgot commented 4 years ago

@Shashankft9 I have updated the image references, can you double check if the issue is fixed using those images?

Shashankft9 commented 4 years ago

@andresmgot I just tested using the new image references in a local kubeless.yaml (configmap), its working fine now, the metrics are coming up.

andresmgot commented 4 years ago

Cool, thanks a lot! I am merging this then.

Shashankft9 commented 4 years ago

Will the new images be reflected while installing Kubeless from here: kubectl create -f https://github.com/kubeless/kubeless/releases/download/v1.0.6/kubeless-v1.0.6.yaml

Shashankft9 commented 4 years ago

anyone looking for the fix can apply this in their cluster in the meantime while there is no new release: https://2824-73902337-gh.circle-artifacts.com/0/build-manifests/kubeless.yaml and restart the kubeless-controller-manager pod.