vmware-archive / runtimes

Kubeless function runtimes: https://kubeless.io/docs/runtimes/

Apache License 2.0

81 stars 89 forks source link

Go Runtime with go mod #71

Closed thspinto closed 4 years ago

thspinto commented 4 years ago

☕ Purpose

Implement Go runtime with go mod as dependency manager.

❓ Questions

Should we create a new runtime for go due to breaking changes?
I used golang as name for the run time, but not sure if it is the best name.
Where to host the official docker image?

🧐 Checklist

[x] Add CI integration
[x] Send to stable dir

🍩 Further details

Let me know what you think of this PR, I'll finish de CI integration after discussing the questions.

thspinto commented 4 years ago

Related Issues

thspinto commented 4 years ago

Hope that makes sense to you!

It does. I'm going to fix the tests and add the instructions to run the legacy version then.

Thanks @andresmgot.

thspinto commented 4 years ago

Done. Ready for review.

andresmgot commented 4 years ago

Thanks for the changes! Do you mind updating the kubeless docs with the new changes here: https://github.com/kubeless/kubeless/blob/master/docs/runtimes.md#go?

thspinto commented 4 years ago

Thanks for the changes! Do you mind updating the kubeless docs with the new changes here: https://github.com/kubeless/kubeless/blob/master/docs/runtimes.md#go?

Sure, I'll send a PR over there! Thanks!