vmware-archive / runtimes

Kubeless function runtimes: https://kubeless.io/docs/runtimes/
Apache License 2.0
81 stars 89 forks source link

add Node.js 14, update default Node.js targets to use 12 #75

Closed knksmith57 closed 4 years ago

knksmith57 commented 4 years ago

I'm not sure how to resolve this build issue. If I'm reading the logs correctly, this is currently failing because stable/nodejs/nodejs.jsonnet doesn't contain an image tagged as kubeless/nodejs:14; but, if so, this is a chicken and egg problem, because that image won't exist until this PR is merged (or the image is manually built and pushed).

whenever y'all have a chance, please let me know if / how I can help resolve this build issue. thanks!

andresmgot commented 4 years ago

Thanks @knksmith57, I have built the image and added it to the manifest. Now it should be properly tested.

knksmith57 commented 4 years ago

awesome, thanks for the speedy turn around!

and just a heads up that I've filed #76 to discuss rebuilding the existing images to pick up security releases. cheers! :beers: