vmware-archive / rvc

RVC is a Linux console UI for vSphere, built on the RbVmomi bindings to the vSphere API.
MIT License
240 stars 48 forks source link

URI parsing syntax does not permit for specifying AD Domain. [RVC 1.7.0][2012-10-02] #61

Open Logos01 opened 12 years ago

Logos01 commented 12 years ago

The current authentication model of RVC does not permit for logins for any vCenter user that is required to declare their AD Domain in order to successfully authenticate against the server.

[ RFC2396 -- https://www.ietf.org/rfc/rfc2396.txt -- Uniform Resource Identifiers (URI): Generic Syntax ] seems to be the syntax by which the login credentials given to RVC are parsed, but they do not permit for the syntax of "DOMAIN\user@hostname"

Without this functionality I have no capability to even attempt a login against my credentials for my vCenter server.

Logos01 commented 12 years ago

Modifying line 37 in rvc-1.7.0/lib/rvc/modules/vim.rb to be: username = URI.decode(uri.user) || ENV['RBVMOMI_USER']

Allows for the use of "%5C" in lieu of the plaintext backslash or escaped backslash in prompt as a work-around to enable authentication with AD Domain declared.

StrangeWill commented 12 years ago

I was the one that helped Logos01 by poking at this, I'll look into making a pull request that properly escapes/unescapes connection data on the vim schema hopefully later today.

cdickmann commented 12 years ago

Thanks for working on a patch. Please include an array of unit tests with this change to make sure the new implementation is strictly better than the old one.

patrobinson commented 10 years ago

Although it's nice to just set the env this commit appears to fix it https://github.com/codemonkeyjohn/rvc/commit/001e52c3d9cbb0b549af4fc7ca7f0226d5e62c34 but still hasn't been merged?

wmotti commented 9 years ago

Any news?

StrangeWill commented 9 years ago

I've had a pull request open for two years that fixes this, bug VMware at this point. :\

ilosamart commented 9 years ago

It seems that VMWare abandoned this repo.