search

vmware-archive / salt-pack

Salt Package Builder
Apache License 2.0
55 stars 23 forks source link

Patch requirements/base.txt to use msgpack-python #546

Closed gtmanfred closed 6 years ago

gtmanfred commented 6 years ago

The requirements file has been updated to use the renamed msgpack, but distributions are still deploying msgpack-python. We will need to patch the requirements file during the package building to make sure that the version that the distribution uses will work correctly with salt so that python knows that the dependency has been met.

ref https://github.com/saltstack/salt/pull/47570

dmurphy18 commented 6 years ago

There is a problem with this ref saltstack/salt#47570 since it is very platform specific, namely Redhat 7.

It can be done either way, the problem I have is a platform specific fix in a non-architecture area. The Debian / Ubuntu family provide a virtual package for msgpack-python, whereas the latest Redhat 7 does not.

Unsure of a better way to address it in a non-platform specific manner than patching for one or the other, but wonder how differences in platform's naming has been handled previously for Python packages.

Just rising it to see if there is some better way to address this in the future other than patching, other than how we handle smartos and esky for Solaris 10 etc.

Never mind, confusing platform package naming with that from PyPI Currently msgpack-python is deprecated but a msgpack-python is still supplied for the latest, that is msgpack-0.5.6.tar.gz and msgpack-python-0.5.6.tar.gz both exist. Hence, not sure if we need to patch at all, given that the next point releases will start using msgpack, and older releases are still able to utilize msgpack-python, and most people will eventually be on a version using msgpack by the time PyPi removes msgpack-python tar ball support (unsure of date, but expect not soon).

dmurphy18 commented 6 years ago

Closing this since both msgpack-0.5.6.tar.gz and msgpack-python-0.5.6.tar.gz should be around for a while