search

vmware-archive / salt-pack

Salt Package Builder
Apache License 2.0
55 stars 23 forks source link

salt-common 2018.3.5+ds-1 drags in ifupdown (on Ubuntu 18.04 LTS, which use netplan) #725

Open otrapeznikov opened 4 years ago

otrapeznikov commented 4 years ago

This issue is identical to https://github.com/saltstack/salt-pack/issues/702

Before the upgrade no ifupdown dependency:

Package: salt-common
Priority: extra
Section: admin
Installed-Size: 26328
Maintainer: Debian Salt Team <pkg-salt-team@lists.alioth.debian.org>
Architecture: all
Source: salt
Version: 2018.3.4+ds-1
Depends: python-apt, python-dateutil, python-jinja2, python-msgpack (>= 0.4), python-pkg-resources, python-requests (>= 1.0.0), python-concurrent.futures, python-tornado (>= 4.2.1), python-yaml, python-systemd, python-psutil, python-gnupg, python:any (<< 2.8), python:any (>= 2.7.5-5~)
Recommends: lsb-release, python-mako
Breaks: python-mako (<< 0.7.0)
Filename: pool/extras/s/salt/salt-common_2018.3.4+ds-1_all.deb
Size: 5929216
MD5sum: c1409199a9e169e82c6aeaa26dbb1e6e
SHA1: ed9956f01803b343513f81161fa3e13cd371b03b
SHA256: 1f719cfd0f849d7c4b678bf302c2e59100c36ffe49baf60809fe1a0c8e7aea13
SHA512: e8c49e3a317130131e94da92746b4117d4459953beb6b6110918f7b18add6c3cdf51c49f1e283aee68b4afd54b3412400aaa7c04fbbc261ec5fe595290cf5201
Description: shared libraries that salt requires for all packages
Description-md5: aaa76a7bda4c75e02b81764c1dc6e91a
Homepage: http://saltstack.org/

After upgrade it has hard dependancy for ifupdown:

Package: salt-common
Priority: extra
Section: admin
Installed-Size: 26484
Maintainer: Debian Salt Team <pkg-salt-team@lists.alioth.debian.org>
Architecture: all
Source: salt
Version: 2018.3.5+ds-1
Depends: python-apt, python-dateutil, python-jinja2, python-msgpack (>= 0.4), python-pkg-resources, python-requests (>= 1.0.0), python-concurrent.futures, python-tornado (>= 4.2.1), python-yaml, python-systemd, python-psutil, python-gnupg, ifupdown, python:any (<< 2.8), python:any (>= 2.7.5-5~)
Recommends: lsb-release, python-mako
Breaks: python-mako (<< 0.7.0)
Filename: pool/extras/s/salt/salt-common_2018.3.5+ds-1_all.deb
Size: 6088964
MD5sum: 140842fd1cf22214cfb53d498af8f45d
SHA1: d8a6a4b4ad13f181bf8e271d7d60bc7914a19a94
SHA256: 333c1d727c5e95dbea24e6b276e5f1983dd0dd7832d56b121297e9ebbc32c37f
SHA512: e447b970bd6ccfe1e680d7fea4508c1b1795ec233982c8d4213151e3abc39e886d0da1a1e101d8b2a7cbd586868471e8ea8e4ae29fdd63f6421a42697197bd3e
Description: shared libraries that salt requires for all packages
Description-md5: aaa76a7bda4c75e02b81764c1dc6e91a
Homepage: http://saltstack.org/
OrangeDog commented 4 years ago

As explained in #702, this was done deliberately as a temporary fix for https://github.com/saltstack/salt/issues/49078 The permanent fix keeps gets accidentally reverted. See #739.

bryceml commented 3 years ago

This appears fixed in 2019.2.2 and newer. Let me know if that's not the case.

OrangeDog commented 3 years ago

It was moved from Depends to Suggests but it's still there. I guess that counts as being fixed @otrapeznikov ?

bryceml commented 3 years ago

I'm fine removing it from suggests if people want that. I don't know which is more helpful to people, having it not there at all, or having it in suggests.

matthewsht commented 3 years ago

Until debian_ip.py is rewritten, shouldn't this revert back to requires, since you get a traceback on network.managed without ifupdown?

OrangeDog commented 3 years ago

@matthewsht Salt works perfectly fine without it if you don't use that state. It shouldn't be forcing non-core dependencies.

matthewsht commented 3 years ago

Is there another state to manage/maintain network interfaces on Debian/Ubuntu?

-- Hunter Matthews Scientific System Engineer [C] NIH/National Human Genome Research Institute @.**@.> | (919) 491-2124

On May 27, 2021, at 7:14 PM, James Howe @.**@.>> wrote:

@matthewshthttps://github.com/matthewsht Salt works perfectly fine without it if you don't use that state. It shouldn't be forcing non-core dependencies.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/saltstack/salt-pack/issues/725#issuecomment-850001287, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATFEQQYSFNBR75OO5D5LF3LTP3G3ZANCNFSM4KTG7NYQ.

OrangeDog commented 3 years ago

@matthewsht file.managed and cmd.run. But the point is you don't have to manage network interfaces in the first place in order to use salt. It's not a required dependency like python or zmq.

matthewsht commented 3 years ago

I understand that argument (and overall I agree with it) - I just wanted to make sure I wasn't missing an option on debian that was obvious to everyone else.

-- Hunter Matthews Scientific System Engineer [C] NIH/National Human Genome Research Institute @.**@.> | (919) 491-2124

On May 28, 2021, at 4:28 AM, James Howe @.**@.>> wrote:

@matthewshthttps://github.com/matthewsht file.managed and cmd.run. But the point is you don't have to manage network interfaces in the first place in order to use salt. It's not a required dependency like python or zmq.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/saltstack/salt-pack/issues/725#issuecomment-850247543, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATFEQQYRWEHDBPHEX42WOVLTP5H2BANCNFSM4KTG7NYQ.