search

vmware-archive / scripted

The Scripted code editor
Eclipse Public License 1.0
1.56k stars 166 forks source link

Remove remaining usages of the `explorer` global variable #216

Closed aeisenberg closed 11 years ago

aeisenberg commented 11 years ago

I am about to remove a reference to the explorer global variable in navHistory.js. Looks like there are 2 more references in contextmenuprovider.js and I can't find anymore. Once these two references are gone, we can remove the global variable (a good thing).

Assigning to Nieraj since he is the owner of contextmenuprovider.js.

nierajsingh commented 11 years ago

Removed reference to window.explorer in contextmenuprovider.js and passed dependency through new context menu API from scripted.js. Also refactored and cleaned up context menu and context menu provider code.

nierajsingh commented 11 years ago

Removed last references to window.explorer from explorer-table and test cases.