search

vmware-archive / scripted

The Scripted code editor
Eclipse Public License 1.0
1.56k stars 166 forks source link

Last few lines of a file are clipped #217

Closed scothis closed 11 years ago

scothis commented 11 years ago

In the main editor, the last four lines of a 156 line file are not visible when scrolled to the bottom of the page. There are visible in the side panel editor.

scothis commented 11 years ago

When refreshing the page, there's a 50-50 chance the last few lines will be accessible.

aclement commented 11 years ago

When this happens is there a jquery message in the js console?

aclement commented 11 years ago

Does it happen only with that file?

aclement commented 11 years ago

Seeing something like this opening our types.js file, the last line is under the footer for me (on chrome). Doesn't happen on firefox.

aclement commented 11 years ago

In my case it is a 'rogue' character in the text. The right arrow (⇒) causes the line size in the editor window to be taller than a regular line. so the line numbers are right and fit on screen but the text in the editor window content is slightly longer and off the bottom of the page. Scott - can you tell if the line numbers are correctly all there and it is the text that is wrong or are they both wrong? (which file is it, maybe I can try it)

scothis commented 11 years ago

I'm having trouble reproducing after resetting the zoom yesterday. I have still seen it, so I'm not sure it's 'fixed'

aclement commented 11 years ago

I believe this is now fixed, at least in dev, not sure the fix has made it into master yet but hopefully we'll have a push to master in the next day or so. I believe it was related to the 'jquery missing' problem which caused sizing problems in layoutmanager.

aclement commented 11 years ago

Since the 'jquery is not defined' issue has been fixed I've seen no more occurrences of problems like this. That fix is now in master, I believe this is now addressed.