search

vmware-archive / scripted

The Scripted code editor
Eclipse Public License 1.0
1.56k stars 166 forks source link

Cannot search for text with a '.' in it using CTRL-J, content assist takes over #257

Closed kdvolder closed 11 years ago

kdvolder commented 11 years ago

CTRL-J is bound to incremental in-file text search.

When I try to search for text with a '.' in it the content assist steals the focus swhen I type a '.'. This makes it completely impossible to search for any text that has a '.' in it.

E.g. 'console.log' or 'console.error'. Those are strings I do wanna be able to search for.

Arguablly content assist should not kick in if some special mode is active only when I'm in regular editing mode. When 'in search mode' keys typed don't actually modify the text in the editor and neither should they be triggering content assist.

aeisenberg commented 11 years ago

Committed a fix. I had to add a new method to textView in scriptedEditor.js so that we could figure out if incremental find is active.