Keybinding ui: various extra bits

vmware-archive / scripted

The Scripted code editor

Eclipse Public License 1.0

1.56k stars 166 forks source link

Keybinding ui: various extra bits #48

Open kdvolder opened 11 years ago

kdvolder commented 11 years ago

Initial implementation of the keybinding UI is very basic. Some things that would be good to add:

a 'reset to default' option/button.
a warning message when rebinding to an already bound keystroke
something to help pick still available keys.

User can 'reset to default' manually, by deleting the keymap file(s) from their .scriptedrc folder and reloading the page. But a button in the UI to do this would be nice.

cawoodm commented 11 years ago

I would also like to see: 1) A way to overwrite a binding in one click without having to create a new one then go in and delete the old one. A "Overwrite" button would do or IMO, this should be the default behaviour of the "Bind" button as you hardly ever want to have 2 bindings. 2) A view of which bindings are default vs. overridden. (* or italic or something) 3) Ability to bind stuff defined in Chrom (Ctrl+L works but F3 doesn't) 4) Help (list of bindings) should disappear when it loses focus

kdvolder commented 11 years ago

Rebinding F3 seems to work just fine for me on linux + Chrome. also tried by a mac person. Perhaps the issue there was the action you tried to rebind not F3.

On Fri, Dec 14, 2012 at 6:51 AM, cawoodm notifications@github.com wrote:

3) Ability to bind stuff defined in Chrom (Ctrl+L works but F3 doesn't)

cawoodm commented 11 years ago

Yes, the action was "Find Next Occurance" which only works if the hotkey is pressed inside the Find dialog. However, whilst Ctrl+K works, F3 (bound to Find Next) inside the dialog doesn't.