search

vmware-archive / springsource-cloudfoundry-samples

Samples for Cloud Foundry
Apache License 2.0
259 stars 182 forks source link

retwis-j database configuration #13

Open hkarakose opened 11 years ago

hkarakose commented 11 years ago

Hi I am going through retwis-j example. The tutorial does not mention about cloudfoundry:

http://docs.spring.io/spring-data/data-keyvalue/examples/retwisj/current/

But spring configuration is set up to use cloudfoundry in applicationContext-redis.xml:

<cloud:service-properties id="cfoundryEnv" />
<context:property-placeholder properties-ref="cfoundryEnv"/>

It looks there is a contradiction with the tutorial and the implementation. Can this be considered as a bug?

scottfrederick commented 11 years ago

The retwis-j tutorial on docs.spring.io is not meant to be Cloud Foundry specific. The version under http://github.com/spring-projects/cloudfoundry-samples/retwisj was created by taking the spring-data sample and making a few small changes for deployment to CF.

The spring-projects/cloudfoundry-samples repo should be considered deprecated. All of the samples in this repo are likely to need some work before they can be deployed to the current CF cleanly, as they were created for an earlier version of CF. I merged your earlier PR thinking it was in the the http://github.com/cloudfoundry-samples org, because I didn't look closely enough at the repo. If you do get it to work on CF I will gladly add it to the cloudfoundry-samples org.

hkarakose commented 11 years ago

Scott, Do you consider updating spring-projects/cloudfoundry-samples/retwisj to work in local environment (without cloud-foundry)?

scottfrederick commented 11 years ago

Such a non-Cloud Foundry-specific version of rewtisj would be in the Spring Data samples here: https://github.com/spring-projects/spring-data-keyvalue-examples. It has been updated recently, so there is a good chance it is in better shape than the one in spring-projects/cloudfoundry-samples.