search

vmware-archive / sql-to-dbsp-compiler

Compiler translating SQL view definitions into DBSP circuits (https://github.com/vmware/database-stream-processor)
Other
28 stars 4 forks source link

Run tests in batches; remove newCircuit() api #95

Closed mihaibudiu closed 1 year ago

mihaibudiu commented 1 year ago

Signed-off-by: Mihai Budiu mbudiu@vmware.com Fixes #94

mihaibudiu commented 1 year ago

This also cleans up the compiler API, removing the newCircuit API.

lalithsuresh commented 1 year ago

LGTM. Is there ever a situation where we'd generate code containing more than one circuit? And if so, I assume the expected usage would be to create multiple DBSPCompiler instances, extract the individual circuits, and then use those to generate code right?

mihaibudiu commented 1 year ago

Not really, compiling multiple circuits shares some structures, such as the Tuple definitions. I will file a bug, since that's now done through static variables; should clean that up too.