Issue: This issue is observed for almost all configuration parameters, when we try to set a GP configuration parameter using gpconfig it does not validate for (1-valid range, 2- datatype) and just blindly sets the parameter in postgresql.conf file.
Correct/Expected behavior
[gpadmin@mdw_ipv4 ~]$ gpconfig -c gp_resource_manager -v 'xyz'
20210716:18:04:42:017593 gpconfig:mdw_ipv4:gpadmin-[CRITICAL]:-new GUC value failed validation: the value of gp_resource_manager must be 'group' or 'queue'
new GUC value failed validation: the value of gp_resource_manager must be 'group' or 'queue'
over 90% of the parameters fail this validation, when set via gpconfig, though the parameter takes INT, Boolean ...etc data type and string datatype with range of valid values, if we set these parameters to a irrelevant value it fails validation and sets in postgresql.conf file.
Generated a file using pg_settings table for all config parameters and try to set it to a junk value 'abc' using gpconfig and it works fine for all most all configuration parameters, and clearly shows validation is missing.
bala-cg
commented
3 years ago
Issue: This issue is observed for almost all configuration parameters, when we try to set a GP configuration parameter using gpconfig it does not validate for (1-valid range, 2- datatype) and just blindly sets the parameter in postgresql.conf file.
Correct/Expected behavior
[gpadmin@mdw_ipv4 ~]$ gpconfig -c gp_resource_manager -v 'xyz' 20210716:18:04:42:017593 gpconfig:mdw_ipv4:gpadmin-[CRITICAL]:-new GUC value failed validation: the value of gp_resource_manager must be 'group' or 'queue' new GUC value failed validation: the value of gp_resource_manager must be 'group' or 'queue'
over 90% of the parameters fail this validation, when set via gpconfig, though the parameter takes INT, Boolean ...etc data type and string datatype with range of valid values, if we set these parameters to a irrelevant value it fails validation and sets in postgresql.conf file.
Generated a file using pg_settings table for all config parameters and try to set it to a junk value 'abc' using gpconfig and it works fine for all most all configuration parameters, and clearly shows validation is missing.