search

vmware-archive / terraforming-aws

Templates to deploy PCF and PKS
Apache License 2.0
64 stars 91 forks source link

Remove credentials and encourage defaults #117

Closed voor closed 5 years ago

voor commented 5 years ago

Resolves #83

This will require changes to your pipeline

Trying to nip this one in the bud, since it's starting to get propagated elsewhere. The hard-coded way we have in terraforming-aws with using access key and secret is going to make things a lot worse down the line for EC2 Roles and session tokens, so remove this practice and reference the documentation on numerous alternatives on how to do this.

voor commented 5 years ago

@nmahoney-pivotal should have the necessary CI/CD pipeline changes now.

voor commented 5 years ago

New push that resolves issue with terraform resource in concourse:

There are some problems with the configuration, described below.

The Terraform configuration must be valid before initialization so that
Terraform can determine which modules and providers need to be installed.

Error: Attribute name required

  on ../modules/infra/networking.tf line 55, in resource "aws_subnet" "public_subnets":
  55:     ignore_changes = ["tags.%", "tags.kubernetes"]

Dot must be followed by attribute name.

Error: Attribute name required

  on ../modules/pks/networking.tf line 40, in resource "aws_subnet" "services_subnets":
  40:     ignore_changes = ["tags.%", "tags.kubernetes"]

Dot must be followed by attribute name.
nwmahoney commented 5 years ago

LGTM :)

Some extra context for anyone else who looks at this: The AWS Provider recommends against using static credentials. The other methods on that page don't require TF variables, so this PR doesn't contain anything to replace the deprecated variables.