search

vmware-archive / terraforming-aws

Templates to deploy PCF and PKS
Apache License 2.0
64 stars 91 forks source link

Created NS record has only 1 value (not 1 per name server) #125

Closed noizwaves closed 4 years ago

noizwaves commented 5 years ago

Summary

When terraforming a control plane with env_name="cp" and dns_suffix="aws.63r53rk54v0r.com" the name sever records are incorrectly being created as a single string, instead of a list of strings.

Happy to be wrong on this, so please let me know if I've got things wrong.

Expected Behavior

expected AWS expected dig

Actual Behavior

actual AWS actual dig

Proposed fix

I've fixed the issue in a hard fork of terraforming-aws in this commit. I'm happy to make this a PR too.

nthomson-pivotal commented 5 years ago

Just got bit by this as well, LetsEncrypt is freaking out when it tries to use DNS challenge with the current configuration.

nwmahoney commented 5 years ago

This got fixed yesterday, but it is part of a larger commit that is still being worked on. @zachgersh could you link the commit here when you push it?

nwmahoney commented 5 years ago

I believe this is the commit. I expect a release containing this fix to be published this week.

genevieve commented 4 years ago

Shipped in v0.52.0