search

vmware-archive / terraforming-aws

Templates to deploy PCF and PKS
Apache License 2.0
64 stars 90 forks source link

Are all the steps documented from running `terraform apply` to getting a running PAS? #90

Open ljfranklin opened 5 years ago

ljfranklin commented 5 years ago

Prompted by this slack convo: https://pivotal.slack.com/archives/C3LQ5CS2X/p1545240977058600. TLDR: We didn't realize you needed to add custom vm_extensions to all LB traffic to reach the GoRouter/SSH proxy. We stumbled onto this CI task which does this but we didn't see any documentation tell us this was necessary.

At minimum, it would be nice to have the vm_extension instructions mentioned in the README and release notes. There's probably also a larger conversation around whether the steps needed to go from terraform apply to a running PAS are sufficiently documented (either in this repo or in official Pivotal docs). Feel free to ping me or anyone else from PAS RelEng team if you're interested in chatting more about this.

voor commented 5 years ago

For what it's worth, I sort of have that here: https://github.com/voor/terraforming-aws/blob/large-changes/terraforming-pas/README.md

Also, this is something achieved a little better by http://docs.pivotal.io/pcf-automation/v1.1/

genevieve commented 4 years ago

@jtarchie Is the vm_extensions setup state part of the automation pipelines? Should we try to document this step either in pivotal docs or in the terraforming repos if it's not covered by p-automator?

jtarchie commented 4 years ago

The vm-extensions are now apart of the configure-director and configure-product config file in om. You create them in configure-director and then a product can consume then. For example, here.

We don't have this documented well with the terraforming repos. We didn't know that things needed to be tagged (vm extension), too. Happy to discuss where this should live.

yogendra commented 4 years ago

I was thinking of baking this in the director-config.yaml like the control-plan stuff. But I am not sure what are the permutation and combinations there.