aws_security_group "control_plane_internal" is unused

vmware-archive / terraforming-aws

Templates to deploy PCF and PKS

Apache License 2.0

64 stars 91 forks source link

aws_security_group "control_plane_internal" is unused #97

Open dherbrich opened 5 years ago

dherbrich commented 5 years ago

The control_plane_internal security group is unused at the moment. I recommend deleting it as it is more restrictive than the default security group ("vms_security_group") which allows all traffic within the vpc. Whats more, with this security group assigned solely the bosh director cannot reach the vms anymore.

https://github.com/pivotal-cf/terraforming-aws/blob/df4ecc78dc410d0dd361017ebb48c96ede47216c/modules/control_plane/network.tf#L29

genevieve commented 4 years ago

Hey @dherbrich. We won't be making changes to the control plane module since it is deprecated. If you'd like this change to be made, could you open a PR? Thanks!