vmware-archive / terraforming-gcp

use terraform, deploy yourself a pcf
Apache License 2.0
71 stars 87 forks source link

Attempting to clarify the conditonal SSL configuration #123

Closed lurraca closed 5 years ago

lurraca commented 5 years ago

While paving our new GCP project with this terraform template we were confused as whether we needed to actually include the properties for SSL certificaties in our terraform.tfvars since they are marked as optional, and while the description of the properties state that we needed one or the other we felt that the presentation of that information made it easy to skim and ignore.

Changes:

Co-authored-by: Scott Muc smuc@pivotal.io

zachgersh commented 5 years ago

@lurraca / @scottmuc, great change thank you so much. If you see any other README.md changes please let us know.

❤️ @zachgersh && @crhntr