search

vmware-archive / terraforming-gcp

use terraform, deploy yourself a pcf
Apache License 2.0
71 stars 87 forks source link

Add backup bucket #140

Closed terminatingcode closed 5 years ago

terminatingcode commented 5 years ago

We added support for backing up GCS blobstores in 2.6+, this PR adds the creation of the backup bucket into the terraform scripts.

https://www.pivotaltracker.com/story/show/158789077

Co-authored-by: Jake Klein jklein@pivotal.io

ciphercules commented 5 years ago

@terminatingcode thanks for the PR! Is a backup GCP bucket in support of a single use case or do you see this as something every PAS deployment should have as default?

aclevername commented 5 years ago

@terminatingcode thanks for the PR! Is a backup GCP bucket in support of a single use case or do you see this as something every PAS deployment should have as default?

This backup bucket should only be used when having an external GCP blobstore, so it should only be needed in the GCP envs

ciphercules commented 5 years ago

@aclevername just to be clear, a default PAS installment on GCP would/should have backup google storage buckets?

aclevername commented 5 years ago

@aclevername just to be clear, a default PAS installment on GCP would/should have backup google storage buckets?

If they are using a remote GCS blobstore instead of an internal, yes.

terminatingcode commented 5 years ago

Hey @Polar-Beard!

Sorry, was on holiday. The support to have backup and restore functionality is a new feature as of PAS 2.6+. I initially made this PR when I realised that the documentation refers to this terraform when explaining how to configure the backup and restore in the PAS tile.

Having another look at the precedent set by the other Terraform module repos, I noticed that the equivalent in AWS would be to toggle the creation of the backup blobstore using a count and a create_backup_pas_buckets variable

Do you feel this is a good pattern for this case as well? Backup storage is an optional configuration not required so I feel this is something that make sense for us to do.

vchrisb commented 5 years ago

the bucket is already only deployed if create_gcs_buckets is enabled, identically to the other buckets.

vchrisb commented 5 years ago

output is missing in terraforming-pas/outputs.tf:

output "backup_bucket" {
  value = "${module.pas.backup_bucket}"
}
alamages commented 5 years ago

Hello @vchrisb, thanks for the feedback! We just added the missing output.