search

vmware-archive / usb-login-scripts

A formal repository for the scripts we use on our SSH-loading USB sticks
Apache License 2.0
28 stars 10 forks source link

Behaviour is confusing & long-winded if already logged in to Chrome #5

Closed cjcjameson closed 4 years ago

davidje13 commented 7 years ago

Hi, can you clarify how this breaks? I've been using it for a while with other people signed in and seen no problems with other people's profiles.

(specifically, the first action is supposed to be that it presses the menu item People->Add Person, then waits for the new window to appear, so it should never interfere with an existing profile)

cjcjameson commented 7 years ago

So, turns out it's not dangerous, but it's a little weird. After opening up a new User Profile in chrome, and having the automated login run, Chrome eventually realizes that I already have a profile on this machine. Ideally, I'd like something to detect that earlier and do the automated Chrome log-in within my existing profile (so I don't have to re-auth my Okta twice, for example).

Is the profile naming significant, interfering with earlier detection?

davidje13 commented 7 years ago

Ah, yes, I have encountered issues if I'm already logged in on a machine. Chrome blocks the same user logging in to multiple sessions on the same machine, but I haven't found an easy way to detect which profiles have already been added.

Current behaviour is that the script will get stuck after the first sign-in, because chrome stops doing what it expects, so it's certainly something which could do with a better flow (detecting that the user is already logged in and just switching to their window rather than performing any login flow would be ideal, I think).

Mind if I re-title this issue?

cjcjameson commented 7 years ago

Go for it! FYI: if I get a chance to hack on this repo some, I'm actually likely to pick up other realms and not touch this part of the feature set.