Import ABC from collections.abc for Python 3.10 compatibility.

vmware-archive / vcd-cli

Command Line Interface for VMware vCloud Director

https://vmware.github.io/vcd-cli

Other

163 stars 104 forks source link

Import ABC from collections.abc for Python 3.10 compatibility. #541

Closed tirkarthi closed 2 years ago

tirkarthi commented 3 years ago

To help us process your pull request efficiently, please include:

Importing ABC directly from collections has been deprecated and will be removed in Python 3.10. Use collections.abc since Python 2 is not supported.

tirkarthi commented 3 years ago

The PR also fixes some of the deprecation warnings as below using pyupgrade https://github.com/asottile/pyupgrade#invalid-escape-sequences

find . -iname '*.py' | xargs -P4 -I{} python3.8 -Wall -m py_compile {}        
./vcd_cli/catalog.py:39: DeprecationWarning: invalid escape sequence \*
  """Work with catalogs in current organization.
./system_tests/login_and_vcd_tests.py:144: DeprecationWarning: invalid escape sequence \.
  version_pattern = re.compile('[0-9]+\.[0-3]+\.[0-9]+')

rocknes commented 2 years ago

fix checked in via https://github.com/vmware/vcd-cli/pull/566