added upload_ovf public and upload_file private methods

vmware-archive / vcloud-rest

Unofficial ruby bindings for VMware vCloud Director®

Apache License 2.0

29 stars 37 forks source link

added upload_ovf public and upload_file private methods #11

Closed frapposelli closed 11 years ago

frapposelli commented 11 years ago

added prerequisites gem to gem spec
added examples to example.rb
upload_file shows progress bar and does put range upload to minimize upload disruption

astratto commented 11 years ago

Applied, thank you so much.

I wonder if we should split upload_ovf in smaller methods...

Note: today or tomorrow I'm going to tag a new release.

frapposelli commented 11 years ago

That was my initial idea, but I didn't see much value in having upload_ovf split up as the library should take care of the whole action (get a vapp uploaded) from start to finish.

astratto commented 11 years ago

You're right, it's just easier to unit test those pieces...

Anyway, it's important to get that feature going, there's always time to refactor it later on.