search

vmware-archive / vcloud-rest

Unofficial ruby bindings for VMware vCloud Director®
Apache License 2.0
29 stars 37 forks source link

Rework regexes #19

Closed fishstick closed 11 years ago

fishstick commented 11 years ago

Hi,

This fixes issue #18 - instead of hard-replacing a string with the url in it, we now match the known last part of the url in a regex and strip that. Also added a spec for specifically that issue (in get_organisations) and rane a rake test;

53 runs, 64 assertions, 0 failures, 0 errors, 0 skips

Edit: Sorry bout the extra commits, forgot to rebase :doh:, but the diff is correct

astratto commented 11 years ago

It seems something weird happened on your branch using git merge... you should use git rebase instead :wink:

I've polished your PR and merged it, I suggest you to drop this branch.

Thanks for the fixes!