search

vmware-archive / vcloud-rest

Unofficial ruby bindings for VMware vCloud Director®
Apache License 2.0
29 stars 37 forks source link

Add vm to vapp and upload iso #24

Closed toddq closed 10 years ago

toddq commented 10 years ago

I added two new methods, one for adding a new VM from a template in an existing vApp, and one to upload ISO media images to a catalog.

astratto commented 10 years ago

@toddq thank you so much for this PR!

It looks good to me, besides that small comment I've made here: https://github.com/astratto/vcloud-rest/pull/24#discussion_r11841332

tarak commented 10 years ago

I couldn't find it in the documentation but in this document:

http://www.vmware.com/files/pdf/products/vCloud/Whats-New-VMware-vCloud-Director-55-Technical-Whitepaper.pdf

It is stated on page 6:

2.1.4 Support for Uploading Any Content Type Prior vCloud Director versions supported uploading ISO images, Open Virtualization Format (OVF) files and floppy disk images to the catalog. vCloud Director 5.5 now supports uploading any type of file to the catalog.

astratto commented 10 years ago

@tarak ok: "vCloud Director 5.5 now supports uploading any type of file to the catalog". So, I'd say that type could become a parameter that defaults to "iso".

@toddq could you make this small change?

Thanks!

toddq commented 10 years ago

I added type as a parameter, but instead of defaulting to iso opted to use the file's extension if a type value isn't provided.

astratto commented 10 years ago

Looks good. Thank you very much!