Some README updates - Githubissues

vmware-archive / vcloud-rest

Unofficial ruby bindings for VMware vCloud Director®

Apache License 2.0

29 stars 37 forks source link

Some README updates #39

Closed esumerfd closed 10 years ago

esumerfd commented 10 years ago

Just fixing some minor things in the README.

coveralls commented 10 years ago

Coverage remained the same when pulling 456fb53158e0426fc2eb7e1cac75059818dca55e on IndependentPurchasingCooperative:master into 1aeccc188a5c1b289884f68394771694ff6bb20f on astratto:master.

coveralls commented 10 years ago

Coverage increased (+1.55%) when pulling 29efb381d16c8223197c26341a1bcbd330d30461 on IndependentPurchasingCooperative:master into 1aeccc188a5c1b289884f68394771694ff6bb20f on astratto:master.

coveralls commented 10 years ago

Coverage increased (+1.62%) when pulling 7d99a6e3c651057c5f2b72538a839e8c1cbbb85e on IndependentPurchasingCooperative:master into 1aeccc188a5c1b289884f68394771694ff6bb20f on astratto:master.

astratto commented 10 years ago

@esumerfd it looks like more commits than expected sneaked in...

Could you please rebase&divide this PR?

esumerfd commented 10 years ago

Hi Stefano, sorry if I did something wrong. Can you explain what you would like me to do?

The first 3 commits represent the initial change and the pull request. Would you like different pull requests for the additional changes?

What specifically are you asking to be rebased and divided?

astratto commented 10 years ago

Hi Ed,

since the PR says "Some README updates" I expect to see only commits related to README.md. :D

If you could divide commits per feature it'd be easier for me to review and merge them.

Thanks

esumerfd commented 10 years ago

Should I create create another pull request per feature?

Since these features are pushed already. What process do you recommend for combining commits?

Sent from Galaxy S5 On Aug 20, 2014 4:12 AM, "Stefano Tortarolo" notifications@github.com wrote:

Hi Ed,

since the PR says "Some README updates" I expect to see only commits related to README.md. :D

If you could divide commits per feature it'd be easier for me to review and merge them.

Thanks

— Reply to this email directly or view it on GitHub https://github.com/astratto/vcloud-rest/pull/39#issuecomment-52746194.

astratto commented 10 years ago

Yes, create different PR please. You can close this one and open others, I'm fine with that.

It'd be great if you could also squash some commits, the rule of thumb here is that a single commit should contain a monolithic feature + tests and a single PR should contain only related commits. That way it's way much easier for me to just review and cherry-pick/merge commits.

Thank you again!