search

vmware-archive / vim-config

This is the Vim configuration we use on pairing machines at Neo, as well as many Neons' personal machines. It's pretty okay.
BSD 2-Clause "Simplified" License
64 stars 41 forks source link

change nerdtree toggle keybind #27

Closed dnlgrv closed 9 years ago

dnlgrv commented 10 years ago

I think we should avoid overriding any of the default vim keybinds, unless it is adding something that works similar to the original.

Something that has always bugged me is that the Neo vim-config changed gt to toggle NERDTree, rather than leaving it as the default :tabnext.

Does anyone else feel the same? I'll always run with this config in my own fork but I'd prefer not to have to!

saterus commented 10 years ago

What is the default keybinding to toggle Nerdtree? I personally toggle it a lot.

dnlgrv commented 10 years ago

I don't think it sets any keybinds for you at all, so there isn't a default keybind for toggle.

saterus commented 10 years ago

I'm not opposed to changing the keybinding. I am opposed to outright removing it.

dnlgrv commented 10 years ago

@saterus Totally agree, that's why I changed it to g rather than taking it out completely. It's a useful keybind, just not at the expense of something else which is also useful.

gabehollombe commented 10 years ago

+1 to keep gt to vim's default keybind of :tabnext. If we want to use a different mapping instead of removing it completely, I'm fine with that.

Bestra commented 10 years ago

I agree. I'm a macvim guy but for a terminal user it's probably a bit maddening. I say we bind nerdtree to F2, which I could swear used to be the nerdtree default.

saterus commented 10 years ago

I don't mind changing it, but :-1: to using F-keys.

dnlgrv commented 10 years ago

Considering I made this PR in March someone should either close it or merge it.

But for the love of god don't use an F-key binding.

nummi commented 10 years ago

+1 leader g

mikem commented 10 years ago

I support reverting gt and gT back to vim's defaults.

In my own config, I map leader-t to :NERDTree and leader-T to :NERDTreeFind.

Bestra commented 10 years ago

In cbus we use leader-t to invoke CtrlP, and it' s pretty entrenched.

mikem commented 10 years ago

Oh yeah, that's right. I use Ctrl+P to invoke CtrlP.

There's gotta be another free key which can be used with the leader to toggle NERDTree.

dnlgrv commented 10 years ago

Well my PR actually changes it to g which I found to be unused.

scssquatch commented 9 years ago

I think we've come to the conclusion that gt and gT should be restored to defaults nad leader g will be nerdtree. We're going to use leader-G for nerdtreefind

scssquatch commented 9 years ago

Opened a new PR that's more up to date with this config change: https://github.com/neo/vim-config/pull/46