vmware-archive / vim-config

This is the Vim configuration we use on pairing machines at Neo, as well as many Neons' personal machines. It's pretty okay.
BSD 2-Clause "Simplified" License
64 stars 41 forks source link

Better process for pull requests #43

Closed paulhenrich closed 9 years ago

paulhenrich commented 10 years ago

Because this is the standard company vim config, I think there should be a higher bar to changing this config dramatically (overriding built-in search/bindings), or for cosmetic preferences (transparency!?).

I propose reverting 3a1a2e7f21518ba9b02a176e4c52447a076318eb and the changes from https://github.com/neo/vim-config/pull/35 that IMO did the opposite of the headline ("unfatten config"). They've both caused some consternation on my project team at neo singapore.

For things like transparency, we have the custom_config directory if someone personally wants that change.

I think the easiest thing is to require review of pull requests and not allow the person that opened it to close it.

scssquatch commented 9 years ago

I agree. Thanks, Paul.