search

vmware-archive / vmw-guestinfo

Apache License 2.0
43 stars 20 forks source link

Porting vmw-guestinfo to the magic world of 32 bits! #11

Closed frapposelli closed 7 years ago

frapposelli commented 7 years ago

It's pretty much that, nothing more.

fdawg4l commented 7 years ago

@dougm I wasn't sure if PCI addressing worked the same on other platforms and could only test on linux64. Just FYI.

frapposelli commented 7 years ago

@dougm right now only vmcheck is constrained on _linux, the asm is constrained on the arch, and afaik there's no way to implement hypervisorPortCheck() without platform specific code, the rest is fine though.

I've replaced the example with rpctool, much better as a working example 😉

sigma commented 7 years ago

very nice. I'm a little bit concerned about the code duplication in 386/amd64 variants, but that can be addressed in a future cleanup PR