search

vmware-archive / vmw-guestinfo

Apache License 2.0
43 stars 20 forks source link

Pure Go implementation of vmw-guestinfo #6

Closed fdawg4l closed 7 years ago

fdawg4l commented 7 years ago

This removes the C dependency and uses a pure Go implementation of the backdoor protocol.

The change is large due to the vendor additions. If you browse the change by commits and leave out the Vendor commit, it should be much more readable.

fdawg4l commented 7 years ago

Following @caglar10ur's and @dougm's advice here. Im going to strip out the vendor changes since they are only for logging and testing. They really aren't necessary. Also, splitting out the C removal into it's own commit so just the new additions can be viewed in isolation. So, standby. I'll forcepush the changes.

fdawg4l commented 7 years ago

I removed the vendor dependencies, and split the commit into 3 parts (removing the C stuff, the go impl, and the license file).

Thanks!

fdawg4l commented 7 years ago

Also i only added a License file which is a copy of the Apache 2.0 License. Please ping if you'd like to use something else and if I need to add file headers including the license to all of the new files.

sigma commented 7 years ago

@fdawg4l thank you SO much for working on this.

@crawford you might be interested in this change, as it makes the whole package Apache-licensed.

crawford commented 7 years ago

Oh, very nice. Thanks for the tip!

fdawg4l commented 7 years ago

Awesome! Thanks guys! I'll post another PR in a day or two with some much needed comments. I also want to pull in the rpc-tool that @caglar10ur made.