search

vmware-archive / vmware-pks-deploy

Code for creating and provisioning a bootstrap VM that assembles a few other repositories for use in automating the deployment of Pivotal Container Engine (PKS).
Other
17 stars 7 forks source link

Customizations for non-pks products. #11

Closed huxoll closed 6 years ago

huxoll commented 6 years ago

Allow $NAME or a file 'solution-name' to provide the actual name of the thing. Allow additional shell scripts (anything named extra*.sh) to further customize the bootstrapped box. Allow additional ansible roles to be added.

vmwclabot commented 6 years ago

@huxoll, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vmwclabot commented 6 years ago

@huxoll, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

tompscanlan commented 6 years ago

We might run into some conflicts with #9. I'm also passing the vm name in via the docker-env file, and the ansible calls have been changed up. Otherwise, LGTM.

vmwclabot commented 6 years ago

@huxoll, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

tompscanlan commented 6 years ago

ok... I dunno how to fix my signoff...

vmwclabot commented 6 years ago

@huxoll, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

tompscanlan commented 6 years ago

ok... I'm done :) . I was trying to resolve the conflict above... used the web editor and got into a weird place... It is now reset to your last commit. will try once again from the command line...

tompscanlan commented 6 years ago

Whee... ok. got it that time.

tompscanlan commented 6 years ago

LGTM