vmware-archive / wavefront-adapter-for-istio

Wavefront by VMware Adapter for Istio is an adapter for Istio to publish metrics to Wavefront by VMware.
Other
14 stars 17 forks source link

Modify default reporting interval to 60s. #100

Closed akodali18 closed 4 years ago

akodali18 commented 4 years ago

Just curious, shouldn't this be based on the flashInterval?

reporting interval controls, when we write to the buffer. In this case, we want to write to buffer every 60s and flush as soon as possible. Increasing flush interval by itself, might cause buffer to get filled up faster than the interval, in which case it would flush automatically and prior to the set interval.